Make serverless hooks work with parallel ToolRunner - #100
Merged
Conversation
This includes the tricky case, where multiple tool calls are launched and *some* of them return results and some need hooks. Approach: * Change hook aborts to raise an Exception instead of cancelling the task * Callers should handle the exception, probably by creating a `pending_tool_result` that has `is_hook_abort=True` * `Agent.run`'s replay handling gets extended to detect this case and merge the tool results into the assistant message for replay. (Maybe this new function, `_process_interrupted_hooks` should just be user facing?)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anbuzin
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the tricky case, where multiple tool calls are launched
and some of them return results and some need hooks.
Approach:
pending_tool_resultthat hasis_hook_abort=TrueAgent.run's replay handling gets extended to detect this caseand merge the tool results into the assistant message for replay.
(Maybe this new function,
_process_interrupted_hooksshould justbe user facing?)